refactor(ast): use = syntax for #[scope] attrs#8878
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 4, 2025
Merged
Conversation
This was referenced Feb 3, 2025
Member
Author
github-actions
bot
added
A-ast
CodSpeed Performance ReportMerging #8878 will not alter performanceComparing Summary
|
overlookmotel
force-pushed
the
02-03-refactor_ast_move_estree_skip_to_types
branch
from
00d3f39 to
3df6dae
Compare
overlookmotel
force-pushed
the
02-03-refactor_ast_use_syntax_for_scope_attrs
branch
from
de94780 to
ef46319
Compare
This was referenced Feb 3, 2025
overlookmotel
force-pushed
the
02-03-refactor_ast_move_estree_skip_to_types
branch
from
3df6dae to
3c771fc
Compare
overlookmotel
force-pushed
the
02-03-refactor_ast_use_syntax_for_scope_attrs
branch
from
ef46319 to
ab2b4fd
Compare
Contributor
Merge activity
|
Change the attributes which specify the scope flags for types from `#[scope(flags(ScopeFlags::Class)]` to `#[scope(flags = ScopeFlags::Class)]`. Ditto `strict_if`. This makes their syntax consistent with other attributes, and will allow simplifying attribute parsing.
graphite-app
bot
force-pushed
the
02-03-refactor_ast_move_estree_skip_to_types
branch
from
3c771fc to
6628e1d
Compare
graphite-app
bot
force-pushed
the
02-03-refactor_ast_use_syntax_for_scope_attrs
branch
from
ab2b4fd to
04786ac
Compare
Base automatically changed from
02-03-refactor_ast_move_estree_skip_to_types
to
main
February 4, 2025 03:51
graphite-app
bot
deleted the
02-03-refactor_ast_use_syntax_for_scope_attrs
branch
This was referenced Feb 4, 2025
graphite-app bot
pushed a commit
that referenced
this pull request
Feb 4, 2025
After #8878, all attributes follow the same pattern. Can now parse all attributes fully, and remove the last vestiges of `syn` types from code generators - they now work entirely with `oxc_ast_tools`'s types (which are simpler).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the attributes which specify the scope flags for types from
#[scope(flags(ScopeFlags::Class)]to#[scope(flags = ScopeFlags::Class)]. Dittostrict_if. This makes their syntax consistent with other attributes, and will allow simplifying attribute parsing.